-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
poc: scheduling gates beta verison #1249
Conversation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
==========================================
- Coverage 61.67% 57.98% -3.70%
==========================================
Files 137 102 -35
Lines 10473 8701 -1772
==========================================
- Hits 6459 5045 -1414
+ Misses 3763 3475 -288
+ Partials 251 181 -70
... and 55 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
64f139a
to
197947f
Compare
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
4385f3e
to
c40413f
Compare
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com> fix operator import Signed-off-by: realanna <anna.reale@dynatrace.com> poc: fix lib import Signed-off-by: realanna <anna.reale@dynatrace.com> poc: fix lib import Signed-off-by: realanna <anna.reale@dynatrace.com> poc: fix lib import Signed-off-by: realanna <anna.reale@dynatrace.com> poc: tidy Signed-off-by: realanna <anna.reale@dynatrace.com> poc: tidy Signed-off-by: realanna <anna.reale@dynatrace.com> poc: tidy Signed-off-by: realanna <anna.reale@dynatrace.com> poc: tidy Signed-off-by: realanna <anna.reale@dynatrace.com> poc: rebased with controller runtime Signed-off-by: realanna <anna.reale@dynatrace.com> poc: up kind version Signed-off-by: realanna <anna.reale@dynatrace.com> poc: removed logger in favour of test logger Signed-off-by: realanna <anna.reale@dynatrace.com> poc: fixed otel Signed-off-by: realanna <anna.reale@dynatrace.com> poc: patched k8s version for sigs.k8s.io/controller-runtime Signed-off-by: realanna <anna.reale@dynatrace.com> poc: added gates Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
aa9005e
to
8d375c2
Compare
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Kudos, SonarCloud Quality Gate passed!
|
This issue has been automatically marked as stale because it has not had recent activity. It will be |
I had to tweak imports of controller runtime since the new version supporting k8s 1.27.1 is not yet released.
for the sake of poc the inner dependencies with klt-cert-manager has been replaced with pr ones for the sake of testing.
A few unit tests need to be fixed due to breaking changes in the library and there is a curious nil pointer issue with the decoder: the interface for injecting it has been removed from controller runtime, so we need to initiate it when creating the handlers kubernetes-sigs/controller-runtime#2134
![image](https://private-user-images.githubusercontent.com/89971034/239868195-ca7df590-d051-4047-808b-1216e1939122.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ1MjYxOTQsIm5iZiI6MTcyNDUyNTg5NCwicGF0aCI6Ii84OTk3MTAzNC8yMzk4NjgxOTUtY2E3ZGY1OTAtZDA1MS00MDQ3LTgwOGItMTIxNmUxOTM5MTIyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI0VDE4NTgxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTlkNTYyODI2ZGZiZmE2YmQxMTJmMGE1Y2ZkNTkxNGYyMTllNGQ3ZmFlMGE0MjUwYWU4YmM0Yjg3MWM5MjE1NjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.X2FpAkTeH3zXcHWUJjv6X1VB2Lw8xSW4B63JLLvuroc)
But overall a separate webhook for gates seems to work.